Add secure HTTP server communication transport - #73
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9159c1ee8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b92ea397b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1faa2d2159
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c01f2ccea2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80a55dada1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (path == null || path.isEmpty()) path = "/"; | ||
| if (!path.endsWith("/")) path += "/"; | ||
| try { | ||
| return new URI("https", null, value.getHost().toLowerCase(Locale.ROOT), value.getPort(), path, null, null); |
There was a problem hiding this comment.
When an HTTPS endpoint uses a percent-escaped base path, such as https://example.com/api%20root/, getRawPath() returns /api%20root/ but this component constructor escapes the percent sign again, producing /api%2520root/. Encoding and parsing a connection code repeats the corruption, so enrollment and transport requests target the wrong reverse-proxy route; preserve the already-escaped raw path when rebuilding the URI.
Useful? React with 👍 / 👎.
| persistState(); | ||
| revocationRetryRequired = false; |
There was a problem hiding this comment.
After a revocation persistence failure, the retry can now persist the removal and clear revocationRetryRequired, but it never clears persistenceFailure; consequently authenticate() continues rejecting every backend certificate until the proxy is restarted even though durable state is consistent again. Fresh evidence in the retry fix is this new successful retry path, which resets only one of the two failure flags; clear the fail-closed flag after the full-state rewrite succeeds.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
mvn -B -f SimpleAPI/pom.xml packageSimpleAPI/target/SimpleAPI.jar(15,044,219 bytes)git diff --check origin/main...HEADNo findings.Integration order
VotingPlugin PR #1594 remains unchanged and will switch to this shared implementation only after this PR is merged and the resulting SimpleAPI artifact is available.